Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getnativecontracts RPC #1724

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Implement getnativecontracts RPC #1724

merged 5 commits into from
Feb 11, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 9, 2021

Close #1680 .

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1724 (4f1bea0) into master (29b1581) will increase coverage by 0.00%.
The diff coverage is 83.22%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1724   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files         270      270           
  Lines       21883    21893   +10     
=======================================
+ Hits        18034    18043    +9     
- Misses       2742     2743    +1     
  Partials     1107     1107           
Impacted Files Coverage Δ
pkg/core/state/contract.go 81.15% <ø> (ø)
pkg/core/native/oracle.go 77.08% <63.63%> (ø)
pkg/rpc/client/rpc.go 86.12% <71.42%> (-0.31%) ⬇️
pkg/core/native/nonfungible.go 82.17% <76.92%> (ø)
pkg/core/native/policy.go 85.93% <78.57%> (ø)
pkg/core/native/name_service.go 81.81% <79.16%> (ø)
pkg/core/native/native_nep17.go 78.26% <87.50%> (ø)
pkg/core/native/native_neo.go 72.46% <88.00%> (ø)
pkg/core/native/management.go 87.74% <88.88%> (-0.05%) ⬇️
pkg/core/blockchain.go 76.74% <100.00%> (+0.07%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b1581...4f1bea0. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel a little uncomfortable without fixed-input client test, but it should be sufficient for now.

@roman-khimov roman-khimov merged commit 2ee755e into master Feb 11, 2021
@roman-khimov roman-khimov deleted the rpc/getnative branch February 11, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement getnativecontracts RPC call
3 participants