core: allow to overload contract methods #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 239 239
Lines 19546 19543 -3
=======================================
- Hits 16157 16155 -2
+ Misses 2392 2389 -3
- Partials 997 999 +2
Continue to review full report at Codecov.
|
AnnaShaleva
approved these changes
Jan 27, 2021
Comment on lines
43
to
45
| md := m.ABI.GetMethod(name, len(stm.Parameters)) | ||
| if md == nil { | ||
| return fmt.Errorf("%w: '%s'", ErrMethodMissing, name) |
There was a problem hiding this comment.
We can also add parameters count to the error message.
Multiple methods with different parameter count can co-exist.
roman-khimov
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple methods with different parameter count can co-exist.
As I understand, only native contracts are affected currently.
Close #1683 .