Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: adjust call flags #1608

Merged
merged 3 commits into from
Dec 11, 2020
Merged

core: adjust call flags #1608

merged 3 commits into from
Dec 11, 2020

Conversation

AnnaShaleva
Copy link
Member

Changes ported from neo-project/neo#2121.

Also new States flag is added and ReadOnly flag is adjusted.
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too red to be true

                            	            	witness #1: signature check failed: vm execution has failed: error encountered at instruction 8 (SYSCALL): failed to invoke syscall: missing call flags: 00001 vs 00100

Previous commit sets AllowCall flag as required for Neo.Native.Call, but
invocation script was loaded with ReadStates flag => native contracts
verification failed.

Other contracts can also make use of AllowCall call flag.
@roman-khimov roman-khimov added this to the v0.92.0 milestone Dec 11, 2020
@roman-khimov roman-khimov merged commit fc36121 into master Dec 11, 2020
@roman-khimov roman-khimov deleted the core/callflags branch December 11, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants