Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error message #140

Closed
dauTT opened this issue Feb 18, 2019 · 2 comments
Closed

improve error message #140

dauTT opened this issue Feb 18, 2019 · 2 comments

Comments

@dauTT
Copy link
Contributor

dauTT commented Feb 18, 2019 •
edited
Loading

As requested by @kim, the error message must follow this convention:

{"jsonrpc":"2.0","error":{"code":-2146233033,"message":"One of the identified items was in an invalid format."},"id":1}

To find more about the context of this issue read here

TODO: refactor the errors methods in the errors.go file accordingly and amends all tests.
@dauTT dauTT mentioned this issue Feb 18, 2019
Merged
@im-kulikov
Copy link
Contributor

Today my PR was merged into neo-project/neo, and I can change that in our repo

@im-kulikov
Copy link
Contributor

Wait until #135 will be merged

im-kulikov added a commit to im-kulikov/neo-go that referenced this issue Feb 19, 2019
@im-kulikov
Fix nspcc-dev#140 (improve error message)
09acaf9 
- return errors like in C# code (neo-project/neo#587)
- update tests
- small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@im-kulikov @dauTT