Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional dBFT phase #112

Closed
roman-khimov opened this issue Apr 1, 2024 · 1 comment
Closed

Additional dBFT phase #112

roman-khimov opened this issue Apr 1, 2024 · 1 comment
Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned
Milestone
v0.3.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we don't have cool new features. We need to update our dBFT protocol for AMEV feature support.

Describe the solution you'd like

  • new phase must be optional
  • it should follow the same logic as other payload exchanges, dBFT shouldn't care much about internals of exchanged data
  • it needs additional tests (hi, Cover state transitions with tests #1, btw)

Additional context

Blocked by #111.
@roman-khimov roman-khimov added U2 Seriously planned S2 Regular significance I2 Regular impact blocked Can't be done because of something feature Completely new functionality labels Apr 1, 2024
@AnnaShaleva AnnaShaleva added this to the v0.3.0 milestone Apr 25, 2024
@roman-khimov roman-khimov removed the blocked Can't be done because of something label Jun 28, 2024
AnnaShaleva added a commit that referenced this issue Jul 12, 2024
@AnnaShaleva
*: support extra dBFT stage
7ea4a6f 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva mentioned this issue Jul 12, 2024
Merged
3 tasks
AnnaShaleva added a commit that referenced this issue Jul 15, 2024
@AnnaShaleva
*: support extra dBFT stage
a2d89af 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 16, 2024
@AnnaShaleva
*: support extra dBFT stage
01f9e6c 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 16, 2024
@AnnaShaleva
*: support extra dBFT stage
be46cb3 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 16, 2024
@AnnaShaleva
*: support extra dBFT stage
3460b23 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 16, 2024
@AnnaShaleva
*: support extra dBFT stage
942dd05 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 17, 2024
@AnnaShaleva
*: support extra dBFT stage
c2f52d3 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 18, 2024
@AnnaShaleva
*: support extra dBFT stage
71118e5 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit that referenced this issue Jul 18, 2024
@AnnaShaleva
*: support extra dBFT stage
b7f4cc0 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov pushed a commit that referenced this issue Jul 30, 2024
@AnnaShaleva @roman-khimov
*: support extra dBFT stage
eea3ee4 
Ref. #112.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva
Copy link
Member

Closed by #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva