Avoiding unnecessary copying (ydb-platform#2413)

nshestakov · Mar 6, 2024 · c8ffbe2 · c8ffbe2
1 parent 2d2ceb9
commit c8ffbe2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ydb/core/persqueue/partition.cpp b/ydb/core/persqueue/partition.cpp
@@ -1832,7 +1832,7 @@ void TPartition::OnProcessTxsAndUserActsWriteComplete(ui64 cookie, const TActorC
     Y_ABORT_UNLESS(cookie == SET_OFFSET_COOKIE);
 
     if (ChangeConfig) {
-        EndChangePartitionConfig(ChangeConfig->Config,
+        EndChangePartitionConfig(std::move(ChangeConfig->Config),
                                  ChangeConfig->TopicConverter,
                                  ctx);
     }
@@ -1906,11 +1906,11 @@ void TPartition::OnProcessTxsAndUserActsWriteComplete(ui64 cookie, const TActorC
     }
 }
 
-void TPartition::EndChangePartitionConfig(const NKikimrPQ::TPQTabletConfig& config,
+void TPartition::EndChangePartitionConfig(NKikimrPQ::TPQTabletConfig&& config,
                                           NPersQueue::TTopicConverterPtr topicConverter,
                                           const TActorContext& ctx)
 {
-    Config = config;
+    Config = std::move(config);
     PartitionConfig = GetPartitionConfig(Config);
     PartitionGraph = MakePartitionGraph(Config);
     TopicConverter = topicConverter;

diff --git a/ydb/core/persqueue/partition.h b/ydb/core/persqueue/partition.h
@@ -318,7 +318,7 @@ class TPartition : public TActorBootstrapped<TPartition> {
     void BeginChangePartitionConfig(const NKikimrPQ::TPQTabletConfig& config,
                                     const TActorContext& ctx);
     void OnProcessTxsAndUserActsWriteComplete(ui64 cookie, const TActorContext& ctx);
-    void EndChangePartitionConfig(const NKikimrPQ::TPQTabletConfig& config,
+    void EndChangePartitionConfig(NKikimrPQ::TPQTabletConfig&& config,
                                   NPersQueue::TTopicConverterPtr topicConverter,
                                   const TActorContext& ctx);
     TString GetKeyConfig() const;