Skip to content

Commit

Permalink
cmd/tailscale/cli: use new Go 1.23 slices.Sorted
Browse files Browse the repository at this point in the history
And a grammatical nit.

Updates tailscale#12912

Change-Id: I9feae53beb4d28dfe98b583373e2e0a43c801fc4
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
  • Loading branch information
bradfitz committed Sep 4, 2024
1 parent 11d205f commit bcc47d9
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions cmd/tailscale/cli/dns-status.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package cli
import (
"context"
"fmt"
"maps"
"slices"
"strings"

Expand Down Expand Up @@ -43,7 +44,7 @@ func runDNSStatus(ctx context.Context, args []string) error {
fmt.Println("This is the DNS configuration provided by the coordination server to this device.")
fmt.Print("\n")
if s.CurrentTailnet == nil {
fmt.Println("No tailnet information available; make sure you're logged into a tailnet.")
fmt.Println("No tailnet information available; make sure you're logged in to a tailnet.")
return nil
} else if s.CurrentTailnet.MagicDNSEnabled {
fmt.Printf("MagicDNS: enabled tailnet-wide (suffix = %s)", s.CurrentTailnet.MagicDNSSuffix)
Expand Down Expand Up @@ -76,12 +77,7 @@ func runDNSStatus(ctx context.Context, args []string) error {
if len(dnsConfig.Routes) == 0 {
fmt.Println(" (no routes configured: split DNS might not be in use)")
}
routesKeys := make([]string, 0, len(dnsConfig.Routes))
for k := range dnsConfig.Routes {
routesKeys = append(routesKeys, k)
}
slices.Sort(routesKeys)
for _, k := range routesKeys {
for _, k := range slices.Sorted(maps.Keys(dnsConfig.Routes)) {
v := dnsConfig.Routes[k]
for _, r := range v {
fmt.Printf(" - %-30s -> %v", k, r.Addr)
Expand Down

0 comments on commit bcc47d9

Please sign in to comment.