Skip to content

Commit

Permalink
health: fix spurious warning about DERP home region '0'
Browse files Browse the repository at this point in the history
Updates tailscale#13650

Change-Id: I6b0f165f66da3f881a4caa25d2d9936dc2a7f22c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
  • Loading branch information
bradfitz committed Oct 22, 2024
1 parent 85241f8 commit ae5bc88
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion health/health.go
Original file line number Diff line number Diff line change
Expand Up @@ -1038,11 +1038,15 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
ArgDuration: d.Round(time.Second).String(),
})
}
} else {
} else if homeDERP != 0 {
t.setUnhealthyLocked(noDERPConnectionWarnable, Args{
ArgDERPRegionID: fmt.Sprint(homeDERP),
ArgDERPRegionName: t.derpRegionNameLocked(homeDERP),
})
} else {
// No DERP home yet determined yet. There's probably some
// other problem or things are just starting up.
t.setHealthyLocked(noDERPConnectionWarnable)
}

if !t.ipnWantRunning {
Expand Down

0 comments on commit ae5bc88

Please sign in to comment.