health: fix magicsockReceiveFuncWarnable health clearing

Fixes tailscale#13204 Change-Id: I7154cdabc9dc362dcc3221fd5a86e21f610bbff0 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
nshalman · Sep 5, 2024 · 13dee9d · 13dee9d
1 parent 3d401c1
commit 13dee9d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/health/health.go b/health/health.go
@@ -1064,14 +1064,15 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
 	_ = t.lastStreamedMapResponse
 	_ = t.lastMapRequestHeard
 
-	shouldClearMagicsockWarnings := false
+	shouldClearMagicsockWarnings := true
 	for i := range t.MagicSockReceiveFuncs {
 		f := &t.MagicSockReceiveFuncs[i]
 		if f.missing {
 			t.setUnhealthyLocked(magicsockReceiveFuncWarnable, Args{
 				ArgMagicsockFunctionName: f.name,
 			})
 			shouldClearMagicsockWarnings = false
+			break
 		}
 	}
 	if shouldClearMagicsockWarnings {