Fix review comments.

ns1 · Dec 12, 2024 · 0c41641 · 0c41641
1 parent 21721d0
commit 0c41641
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/rest/alert.go b/rest/alert.go
@@ -162,7 +162,7 @@ func (s *AlertsService) Replace(alert *alerting.Alert) (*http.Response, error) {
 	return resp, nil
 }
 
-// Delete immediately deletes an existing alert.
+// Delete deletes an existing alert.
 //
 // NS1 API docs: https://ns1.com/api/#alert-alertid-delete
 func (s *AlertsService) Delete(alertID string) (*http.Response, error) {

diff --git a/rest/alert_test.go b/rest/alert_test.go
@@ -138,7 +138,6 @@ func TestAlert(t *testing.T) {
 			compareAlerts(t, alertResponse, &alertToCreate)
 		})
 
-		// TODO Add test for error response when updating fields that can't be changed.
 		t.Run("Error Duplicate Name", func(t *testing.T) {
 			defer mock.ClearTestCases()
 

diff --git a/rest/model/alerting/alert.go b/rest/model/alerting/alert.go
@@ -22,8 +22,6 @@ var (
 	recordAlertType string = "record"
 )
 
-// TODO - Allow zones/notifier lists to be passed as structs?
-//   - Multiple constructors?
 func NewZoneAlert(alertName string, subtype string, notifierListIds []string, zoneNames []string) *Alert {
 	return &Alert{
 		Name:            &alertName,