Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): infer continuous tasks for storybook serve and serve-static #30069

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 17, 2025

Current Behavior

The @nx/storybook/plugin does not set continuous:true for serve-like targets.

Expected Behavior

The plugin should correctly set continuous: true for serve and serve-static.

@Coly010 Coly010 requested a review from a team as a code owner February 17, 2025 13:51
@Coly010 Coly010 self-assigned this Feb 17, 2025
@Coly010 Coly010 requested a review from jaysoo February 17, 2025 13:51
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 1:54pm

Copy link

nx-cloud bot commented Feb 17, 2025

View your CI Pipeline Execution ↗ for commit 1f91f15.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 41s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 8s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 1m 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-17 14:24:05 UTC

@Coly010 Coly010 enabled auto-merge (squash) February 17, 2025 14:28
@Coly010 Coly010 merged commit b7d8e57 into next-major Feb 18, 2025
12 checks passed
@Coly010 Coly010 deleted the storybook/continuous-tasks branch February 18, 2025 17:41
FrozenPandaz pushed a commit that referenced this pull request Feb 20, 2025
…-static (#30069)

## Current Behavior
The `@nx/storybook/plugin` does not set `continuous:true` for serve-like
targets.

## Expected Behavior
The plugin should correctly set `continuous: true` for `serve` and
`serve-static`.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants