Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated tsconfig path mapping for publishable libs (when generated in nested folders) #2840

Merged
merged 5 commits into from
Jul 22, 2020
Merged

fix: generated tsconfig path mapping for publishable libs (when generated in nested folders) #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f34441
fix(angular): require importPath for publishable libs & adjust buildable
juristr Jun 5, 2020
28d84fc
fix(react): require importPath for publishable libs & adjust buildable
juristr Jun 11, 2020
7cb5ae4
fix(node): require importPath for publishable libs & adjust buildable
juristr Jun 12, 2020
20263f1
fix(nest): require importPath for publishable libs & adjust buildable
juristr Jun 28, 2020
1e4e681
fix(nx-plugin): require importPath
juristr Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions docs/angular/api-angular/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,26 @@ Type: `boolean`

Add a module spec file.

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### directory

Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### lazy

Default: `false`
Expand Down Expand Up @@ -72,13 +86,11 @@ The prefix to apply to generated selectors.

### publishable

Alias(es): buildable

Default: `false`

Type: `boolean`

Generate a buildable library.
Generate a publishable library.

### routing

Expand Down
18 changes: 15 additions & 3 deletions docs/angular/api-nest/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ nx g lib mylib --directory=myapp

## Options

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### controller

Default: `false`
Expand All @@ -60,6 +68,12 @@ Type: `boolean`

Add the Global decorator to the generated module.

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### linter

Default: `tslint`
Expand All @@ -78,11 +92,9 @@ Library name

### publishable

Alias(es): buildable

Type: `boolean`

Create a buildable library.
Create a publishable library.

### service

Expand Down
16 changes: 14 additions & 2 deletions docs/angular/api-node/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ nx g lib mylib --directory=myapp

## Options

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### directory

Alias(es): d
Expand All @@ -44,6 +52,12 @@ Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### linter

Default: `tslint`
Expand All @@ -62,8 +76,6 @@ Library name

### publishable

Alias(es): buildable

Type: `boolean`

Create a publishable library.
Expand Down
8 changes: 7 additions & 1 deletion docs/angular/api-nx-plugin/schematics/plugin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ nx g plugin ... --dry-run
Generate libs/plugins/my-plugin:

```bash
nx g plugin my-plugin --directory=plugins
nx g plugin my-plugin --directory=plugins --importPath=@myorg/my-plugin
```

## Options
Expand All @@ -40,6 +40,12 @@ Type: `string`

A directory where the plugin is placed

### importPath

Type: `string`

How the plugin will be published, like @myorg/my-awesome-plugin. Note this must be a valid npm name

### linter

Default: `tslint`
Expand Down
18 changes: 15 additions & 3 deletions docs/angular/api-react/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ Type: `string`

The application project to add the library route to.

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### component

Default: `true`
Expand All @@ -66,6 +74,12 @@ Type: `string`

A directory where the lib is placed.

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib

### js

Default: `false`
Expand Down Expand Up @@ -102,11 +116,9 @@ Use pascal case component file name (e.g. App.tsx).

### publishable

Alias(es): buildable

Type: `boolean`

Create a buildable library.
Create a publishable library.

### routing

Expand Down
6 changes: 6 additions & 0 deletions docs/angular/api-workspace/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib

### linter

Default: `tslint`
Expand Down
18 changes: 15 additions & 3 deletions docs/react/api-angular/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,26 @@ Type: `boolean`

Add a module spec file.

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### directory

Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### lazy

Default: `false`
Expand Down Expand Up @@ -72,13 +86,11 @@ The prefix to apply to generated selectors.

### publishable

Alias(es): buildable

Default: `false`

Type: `boolean`

Generate a buildable library.
Generate a publishable library.

### routing

Expand Down
18 changes: 15 additions & 3 deletions docs/react/api-nest/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ nx g lib mylib --directory=myapp

## Options

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### controller

Default: `false`
Expand All @@ -60,6 +68,12 @@ Type: `boolean`

Add the Global decorator to the generated module.

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### linter

Default: `tslint`
Expand All @@ -78,11 +92,9 @@ Library name

### publishable

Alias(es): buildable

Type: `boolean`

Create a buildable library.
Create a publishable library.

### service

Expand Down
16 changes: 14 additions & 2 deletions docs/react/api-node/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ nx g lib mylib --directory=myapp

## Options

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### directory

Alias(es): d
Expand All @@ -44,6 +52,12 @@ Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib. Must be a valid npm name.

### linter

Default: `tslint`
Expand All @@ -62,8 +76,6 @@ Library name

### publishable

Alias(es): buildable

Type: `boolean`

Create a publishable library.
Expand Down
8 changes: 7 additions & 1 deletion docs/react/api-nx-plugin/schematics/plugin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ nx g plugin ... --dry-run
Generate libs/plugins/my-plugin:

```bash
nx g plugin my-plugin --directory=plugins
nx g plugin my-plugin --directory=plugins --importPath=@myorg/my-plugin
```

## Options
Expand All @@ -40,6 +40,12 @@ Type: `string`

A directory where the plugin is placed

### importPath

Type: `string`

How the plugin will be published, like @myorg/my-awesome-plugin. Note this must be a valid npm name

### linter

Default: `tslint`
Expand Down
18 changes: 15 additions & 3 deletions docs/react/api-react/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ Type: `string`

The application project to add the library route to.

### buildable

Default: `false`

Type: `boolean`

Generate a buildable library.

### component

Default: `true`
Expand All @@ -66,6 +74,12 @@ Type: `string`

A directory where the lib is placed.

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib

### js

Default: `false`
Expand Down Expand Up @@ -102,11 +116,9 @@ Use pascal case component file name (e.g. App.tsx).

### publishable

Alias(es): buildable

Type: `boolean`

Create a buildable library.
Create a publishable library.

### routing

Expand Down
6 changes: 6 additions & 0 deletions docs/react/api-workspace/schematics/library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ Type: `string`

A directory where the lib is placed

### importPath

Type: `string`

The library name used to import it, like @myorg/my-awesome-lib

### linter

Default: `tslint`
Expand Down
Loading