feat(react-native): add convert-to-inferred generator for Expo and React Native #27326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2b6f5a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
c521778 to
1d43fa4
Compare
ndcunningham
reviewed
Aug 7, 2024
ndcunningham
reviewed
Aug 7, 2024
packages/expo/src/generators/convert-to-inferred/lib/post-target-transformer.ts
Outdated
Show resolved
Hide resolved
packages/expo/src/generators/convert-to-inferred/lib/process-prebuild-options.ts
Outdated
Show resolved
Hide resolved
packages/expo/src/generators/convert-to-inferred/lib/process-install-options.ts
Outdated
Show resolved
Hide resolved
packages/expo/src/generators/convert-to-inferred/lib/process-build-options.ts
Outdated
Show resolved
Hide resolved
1d43fa4 to
a461c1b
Compare
a461c1b to
089497a
Compare
ba8095a to
a661171
Compare
a661171 to
0015cc4
Compare
isaacplmann
approved these changes
Aug 8, 2024
f032959 to
d875fc7
Compare
Coly010
approved these changes
Aug 8, 2024
Comment on lines
15
to
5
| * Remove pod-install from dependsOn for all targets, it does pod-install when creating the app | ||
| */ |
Coly010
reviewed
Aug 8, 2024
| workspaceRoot, | ||
| } from '@nx/devkit'; | ||
|
|
||
| import { runCliUpgrade } from '../../executors/upgrade/upgrade.impl'; |
e141af0 to
894155d
Compare
894155d to
8aa769d
Compare
8aa769d to
1dd3c57
Compare
1dd3c57 to
2b6f5a0
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
convert-to-inferredgenerators to convert React Native an Expo apps using executors to use the corresponding inference plugins.Also:
@nx/react-native/pluginso it is correctly set asupgradeTargetNamenotupgradeTargetname