-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore(repo): improve the devcontainer
setup
#27221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3dd72fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ee9fe67
to
9648096
Compare
I'll let Jason or Victor approve the changes. The docs look fine. How often does the version of |
From what I have understood, When I initially setup the devcontainer, |
also I think the As for automating the entire thing starting from the base image that is used by the devcontainer, maybe we can create a small script that would extract it and run the underlying That way we can spot when the image needs to be updated. I can look into that and provide another PR if the idea is validated? |
cb520a3
to
509ccb4
Compare
Any progress on reviewing this ? @FrozenPandaz @vsavkin |
509ccb4
to
530cef3
Compare
- respect `pnpm` version declared in root `package.json` - improve disk performances when installing node modules - add troubleshooting instructions in `CONTRIBUTING.md` to help solve common issue related to outdated `GLIBC` version - add port forwarding for `verdaccio` to allow quickly inspecting the packages install in verdaccio local registry
24977b3
to
3dd72fb
Compare
Thanks for approving/merging this. Another thing that we can do, to optimize/improve the DX when opening the repo in |
@isaacplmann do you want me to investigate how to automate the update of the devcontainer image as described here ? |
I wouldn't worry about doing that right now. If it is automatically handling patch and minor versions, we can manually handle major versions. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
pnpm
version declared in rootpackage.json
CONTRIBUTING.md
to help solve common issue related to outdatedGLIBC
version