Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): support ts-node options in tsconfig files #21723

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

forivall
Copy link
Contributor

@forivall forivall commented Feb 8, 2024

Current Behavior

The tsconfig.json is no longer being read by ts-node, and the ts-node specific options are also not being passed to ts-node.

Expected Behavior

The "ts-node" specific options should be read from the tsconfig.json files, ideally through the entire extends chain.

Related Issue(s)

Fixes #21695 - this PR doesnt read through the extends chain, but it solves my use case, where the options are in the tsconfig.base.json file. We can document that limitation, and I think it's a clear tradeoff.

@forivall forivall requested a review from a team as a code owner February 8, 2024 17:31
@forivall forivall requested a review from Cammisuli February 8, 2024 17:31
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 7:24pm

@forivall forivall force-pushed the forivall/ts-node-support-options branch 2 times, most recently from f7d6b64 to b80bff9 Compare February 14, 2024 22:59
@forivall forivall changed the base branch from master to 18.0.x February 15, 2024 00:18
@forivall forivall force-pushed the forivall/ts-node-support-options branch from b80bff9 to 7ead5d5 Compare February 15, 2024 00:20
@forivall forivall requested a review from jaysoo as a code owner February 15, 2024 00:20
@AgentEnder AgentEnder force-pushed the forivall/ts-node-support-options branch from 65c5bd4 to 8ae4440 Compare June 4, 2024 15:21
@AgentEnder AgentEnder enabled auto-merge (squash) June 4, 2024 15:28
@AgentEnder AgentEnder force-pushed the forivall/ts-node-support-options branch from 8ae4440 to 88c6ee2 Compare June 4, 2024 19:22
@AgentEnder AgentEnder merged commit 8800a30 into nrwl:master Jun 4, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts-node does not use compiler configured in tsconfig.json
2 participants