-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): support ts-node options in tsconfig files #21723
fix(misc): support ts-node options in tsconfig files #21723
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 88c6ee2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
f7d6b64
to
b80bff9
Compare
b80bff9
to
7ead5d5
Compare
65c5bd4
to
8ae4440
Compare
8ae4440
to
88c6ee2
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The tsconfig.json is no longer being read by ts-node, and the ts-node specific options are also not being passed to ts-node.
Expected Behavior
The
"ts-node"
specific options should be read from the tsconfig.json files, ideally through the entireextends
chain.Related Issue(s)
Fixes #21695 - this PR doesnt read through the extends chain, but it solves my use case, where the options are in the
tsconfig.base.json
file. We can document that limitation, and I think it's a clear tradeoff.