feat(core): add native node bindings for hashing #14476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ab932eb to
b30c9fd
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 715293d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
eeb053c to
84f5729
Compare
Update native builds to only install nx and build
ce3fd5d to
79e2529
Compare
79e2529 to
9fa936b
Compare
9fa936b to
c8be662
Compare
c8be662 to
a505f08
Compare
ff023e5 to
7997118
Compare
7997118 to
715293d
Compare
FrozenPandaz
approved these changes
Jan 31, 2023
|
|
||
| let git_folder = workspace_root.clone() + ".git"; | ||
| // We should make sure to always ignore node_modules | ||
| let node_folder = workspace_root.clone() + "node_modules"; |
There was a problem hiding this comment.
We need to handle nested node_modules directories too.
|
Don't merge this yet. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Current implementation of our file hashers uses a node based one and a git one. We fallback to the node implementation when a workspace isn't a git workspace (like using other version control systems), and when we do, hashing becomes very slow.
Moreover, using git to do our hashing is very quick, but requires a lot of "hand waving" to get things working well. Also, when there are a lot of changes in the workspace (i.e merging branches, etc) the git hasher becomes slow as well.
Expected Behavior
This PR introduces a native hasher, that is built with Rust. Right now it's feature flagged behind the
NX_NATIVE_HASHERenv variable.This allows us to have consistent performance, and have more control over the hashing.
This PR also changes how we publish Nx as we will need to build a native binary for all the platforms we support, which are the following:
Related Issue(s)
Fixes #