fix(linter): migrate no-extra-semi rules into user config, out of nx …

…extendable configs (#26011)
nrwl · May 24, 2024 · be6453c · be6453c
1 parent 10f97b9
commit be6453c
Show file tree

Hide file tree

Showing 5 changed files with 508 additions and 4 deletions.
diff --git a/packages/eslint-plugin/migrations.json b/packages/eslint-plugin/migrations.json
@@ -11,6 +11,12 @@
       "version": "17.2.6-beta.1",
       "description": "Rename workspace rules from @nx/workspace/name to @nx/workspace-name",
       "implementation": "./src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules"
+    },
+    "update-19-1-0-rename-no-extra-semi": {
+      "cli": "nx",
+      "version": "19.1.0-beta.6",
+      "description": "Migrate no-extra-semi rules into user config, out of nx extendable configs",
+      "implementation": "./src/migrations/update-19-1-0-migrate-no-extra-semi/migrate-no-extra-semi"
     }
   },
   "packageJsonUpdates": {},

diff --git a/packages/eslint-plugin/src/configs/javascript.ts b/packages/eslint-plugin/src/configs/javascript.ts
@@ -57,8 +57,6 @@ export default {
      *
      * TODO(v20): re-evalute these deviations from @typescript-eslint/recommended in v20 of Nx
      */
-    'no-extra-semi': 'off',
-    '@typescript-eslint/no-extra-semi': 'error',
     '@typescript-eslint/no-non-null-assertion': 'warn',
     '@typescript-eslint/adjacent-overload-signatures': 'error',
     '@typescript-eslint/prefer-namespace-keyword': 'error',

diff --git a/packages/eslint-plugin/src/configs/typescript.ts b/packages/eslint-plugin/src/configs/typescript.ts
@@ -40,8 +40,6 @@ export default {
      *
      * TODO(v20): re-evalute these deviations from @typescript-eslint/recommended in v20 of Nx
      */
-    'no-extra-semi': 'off',
-    '@typescript-eslint/no-extra-semi': 'error',
     '@typescript-eslint/no-non-null-assertion': 'warn',
     '@typescript-eslint/adjacent-overload-signatures': 'error',
     '@typescript-eslint/prefer-namespace-keyword': 'error',