Skip to content

Commit

Permalink
fix(nx-dev): Turn off next.js cache for careers api (#27275)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Currently, in Next.js 14 the `fetch` API is cached by default, which we
do not want on the careers page.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Each visit to the careers page should do a fresh API call.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 8d7fe2f)
  • Loading branch information
ndcunningham authored and FrozenPandaz committed Aug 7, 2024
1 parent 11f96cd commit 2ef1c54
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion nx-dev/data-access-careers/src/lib/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Job, LeverJob } from './models';
export async function fetchJobsList(): Promise<Job[]> {
const apiUrl = 'https://api.lever.co/v0/postings/nrwl?mode=json';

const res = await fetch(apiUrl);
const res = await fetch(apiUrl, { cache: 'no-store' });

if (res.ok) {
const data = (await res.json()) as LeverJob[];
Expand Down
4 changes: 2 additions & 2 deletions nx-dev/data-access-careers/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
"outDir": "../../dist/out-tsc",
"types": [
"node",

"@nx/react/typings/cssmodule.d.ts",
"@nx/react/typings/image.d.ts"
]
],
"lib": ["dom"]
},
"exclude": [
"jest.config.ts",
Expand Down

0 comments on commit 2ef1c54

Please sign in to comment.