Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): quality of life improvements for Remix generators #216

Merged
merged 10 commits into from
Apr 13, 2023

Conversation

philipjfulcher
Copy link
Contributor

@philipjfulcher philipjfulcher commented Apr 12, 2023

This PR adds some quality of life improvements to the Remix generators:

  • Generators now generate code closer to the typing standards of the Remix community:
const data = useLoaderData<typeof loader>();

// instead of

const data = useLoaderData<LoaderDataInterface>();
  • Route params are no longer changed from camel-case to snake-case
  • Route paths are checked for the very common error of an un-escaped $. The $ is used in Remix for route params, but it's used for interpolation by many shells.
  • The path to the Remix app directory is now resolved correctly if it has been changed in remix.config.ts
  • Generators have been updated for better compatibility with standalone and integrated workspace
  • More test and e2e coverage for Remix plugin
  • Fixes the cypress generator by adding a fix for Remix.js React 18 Hydration Error remix-run/remix#5569 so that the first test passes

@philipjfulcher philipjfulcher force-pushed the philip/remix-generators branch from 1785c6b to b286db4 Compare April 12, 2023 17:15
@philipjfulcher philipjfulcher merged commit e159c50 into nrwl:main Apr 13, 2023
@philipjfulcher philipjfulcher deleted the philip/remix-generators branch April 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants