fix: a better fix for the deleted PartInstance problem

[jstarpl]

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

#1358 introduced a bugfix for an issue where the current MOS Story for the Next PartInstance is deleted which caused the ingest & playout side to "lock up", unable to create the Playout Model. That fix, while working, is problematic because:

1. It's not merge-able into release52
2. It breaks the overall flow of data through the models, by causing a playout-related decision to be made at ingest time.

New Behavior

The fix is reworked into a new algorithm that:

1. Prevents the deletion of the Segment containing the nextPart instance
2. Allows the flow to be unchanged up until ensureNextPartIsValid
3. Allows ensureNextPartIsValid to discover that the next PartInstance is orphaned: deleted and select something else (much like the fix from #1358)
4. The PartInstance and Segment are deleted later during a clean-up job, because they are no longer linked to the Rundown.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

• This PR affects the playout and ingest logic in general.

Time Frame

• We intend to finish the development on this feature in two weeks time.

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.98%. Comparing base (baacf0e) to head (b480cc8).

Additional details and impacted files

@@              Coverage Diff              @@
##           release51    #1360      +/-   ##
=============================================
- Coverage      58.00%   57.98%   -0.03%     
=============================================
  Files            525      525              
  Lines          85240    85218      -22     
  Branches        4462     4457       -5     
=============================================
- Hits           49445    49412      -33     
- Misses         35740    35773      +33     
+ Partials          55       33      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nytamin]

Yes, this better fix looks reasonable to me!