Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process environment variables and restyle settings #14

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

This PR adds the possibility to set environment variables for the processes being run.

To achieve this, the settings ui has been reworked a bit, as the processes table has been very cluttered for a long time due to the number of columns

Before:
Screenshot from 2024-11-11 13-40-53

After:
Screenshot from 2024-11-11 13-40-05
Screenshot from 2024-11-11 13-40-14

Testing Instructions

Other Information

This code isn't particularly nice, but I do not know enough about vue data binding to split it out into the multiple components that it should be.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team November 11, 2024 14:10
@nytamin nytamin merged commit 9cdf0b3 into nrkno:master Dec 16, 2024
@nytamin nytamin deleted the feat/env-vars branch December 16, 2024 08:27
@nytamin
Copy link
Contributor

nytamin commented Dec 16, 2024

This is inclueded in version 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants