feat: add setting to choose process stdin encoding #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
"This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Bug fix / Feature
New Behavior
When using CasparCG 2.4, the 'send command' field does not work. This is because the process is expecting utf16 encoded messages, but the launcher is sending utf8.
Changing this breaks other processes (such as CasparCG 2.1). To avoid this, it has been added as a new field in the processes table. This also means it can be disabled for a process, hiding the useless field for the media-scanner.
Testing Instructions
This has been tested with CasparCG 2.1, CasparCG 2.4 and the latest media-scanner.
Other Information
This was not a trivial or fun change to make. This project is running very old dependencies (expecting node 12 to be used), and using vue which is not used elsewhere in the Sofie stack.
I understand that this is a known hazard of a simple tool that needs little development, someone at some point might want to look into updating to latest electron, and possibly switching the ui to react.
Status