nrf_modem: add dectphy flavour #1325

lemrey · 2024-05-07T10:25:56Z

Add libmodem dectphy flavour; update documentation.

eivindj-nordic · 2024-05-07T11:24:13Z

nrf_modem/include/nrf_modem_gnss.h

@@ -1351,7 +1351,7 @@ int32_t nrf_modem_gnss_agnss_write(void *buf, int32_t buf_len, uint16_t type);
 * @details Returns detailed information about the current GNSS A-GNSS data need. The data
 *          structure contains expiry times in seconds for different types of assistance data.
 *          This function can be called at any time. If GNSS doesn't know the current GPS
- *          system time, the expiry times cannot be calculated.
+ *          system time, the expiry times can not be calculated


nit

Suggested change

* system time, the expiry times can not be calculated

* system time, the expiry times can not be calculated.

Let's fix this in libmodem repo instead.

nrf_modem/doc/dectphy.rst

eivindj-nordic · 2024-05-07T12:42:41Z

nrf_modem/doc/dectphy.rst

+Afterwards, the application can initialize the DECT PHY interface by calling the :c:func:`nrf_modem_dect_phy_init` function.
+Upon successful initialization, both the DECT PHY interface and DECT NR+ physical layer in the modem are ready for operation.
+
+The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware will perform a product locking procedure.


Should we add some explanation on what that means?

Thanks for reminding me, I will check with Jaakko.

eivindj-nordic · 2024-05-08T07:24:07Z

nrf_modem/doc/dectphy.rst

+Transmission length
+-------------------
+
+Transmissions take time, that is, they have a length.


This sentence seem a bit unnecessary

It introduces the fact that the length of a transmission has two dimensions, time and size. When talking about the "length of a transmission", you could mean two things, the time it takes to transmit and how much data you are transmitting, which is what this chapter explains.

Ok, thanks for clarifying what you mean by it, though I still find the sentence a bit confusing.
What about incorporating it in the sentence below, e.g.

The *transmission* length is expressed in sub-slots, where each sub-slot has a size in time, given by the subcarrier scaling factor. A transmission may take up to 15 sub-slots, where the number of bits per subslot is decided by the chosen modulation scheme. This is shown in the table below. The length of the *data* being transmitted is expressed in bytes, and is specified by the :c:member:`nrf_modem_dect_phy_tx_params.data_size` parameter.

divipillai · 2024-05-08T12:47:28Z

nrf_modem/doc/CHANGELOG.rst

+DECT NR+
+========
+
+* Added new interface for DECT NR+ PHY firmware.


Suggested change

* Added new interface for DECT NR+ PHY firmware.

* Added new :ref:`interface <nrf_modem_dect_phy>` for the DECT NR+ PHY firmware.

To link to the documentation.

Thanks, updated

divipillai · 2024-05-08T14:45:48Z

nrf_modem/doc/CHANGELOG.rst

@@ -9,6 +9,17 @@ Changelog

 All notable changes to this project are documented in this file.

+nrf_modem


Shouldn't the version be mentioned here.

Not anymore, we will put a number there once we tag NCS.

divipillai · 2024-05-08T14:48:07Z

nrf_modem/doc/dectphy.rst

+Regulations
+***********
+
+DECT NR+ operates on free but regulated radio channels. The availability of the channels and the exact regulation to use them varies in different countries.


Suggested change

DECT NR+ operates on free but regulated radio channels. The availability of the channels and the exact regulation to use them varies in different countries.

DECT NR+ operates on free but regulated radio channels.

The availability of the channels and the exact regulations for using them vary in different countries.

divipillai · 2024-05-08T14:54:11Z

nrf_modem/doc/dectphy.rst

+
+The physical layer is only one part of the DECT-2020 New Radio protocol stack (DECT NR+).
+
+The whole DECT NR+ protocol stack consist of four layers:


Suggested change

The whole DECT NR+ protocol stack consist of four layers:

The whole DECT NR+ protocol stack consists of four layers:

divipillai · 2024-05-08T14:55:57Z

nrf_modem/doc/dectphy.rst

+Afterwards, the application can initialize the DECT PHY interface by calling the :c:func:`nrf_modem_dect_phy_init` function.
+Upon successful initialization, both the DECT PHY interface and DECT NR+ physical layer in the modem are ready for operation.
+
+The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware will perform a product locking procedure.


Suggested change

The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware will perform a product locking procedure.

The very first time the DECT PHY interface is initialized, the DECT NR+ PHY firmware performs a product locking procedure.

divipillai · 2024-05-08T15:41:32Z

nrf_modem/doc/dectphy.rst

+
+The DECT physical layer (PHY) interface in the Modem library is used to control the DECT NR+ PHY in the DECT NR+ PHY firmware.
+
+The DECT NR+ PHY firmware is a variant of the nRF9161 firmware with a different feature set than the cellular firmware.


Should we refer as nRF91x1 modem firmware, considering this will be also applicable for nRF9151 as well?

divipillai · 2024-05-08T15:43:26Z

nrf_modem/doc/dectphy.rst

+* Physical layer (PHY)
+* Medium Access Control (MAC) layer, including co-existing and channel access operation
+* Data link control (DLC), including routing, segmentation and re-assembly of messages
+* Convergence layer (CVG), including message flow control, multiplexing and transmission service level control


Suggested change

* Physical layer (PHY)

* Medium Access Control (MAC) layer, including co-existing and channel access operation

* Data link control (DLC), including routing, segmentation and re-assembly of messages

* Convergence layer (CVG), including message flow control, multiplexing and transmission service level control

* Physical layer (PHY).

* Medium Access Control (MAC) layer, including co-existing and channel access operation.

* Data link control (DLC), including routing, segmentation and re-assembly of messages.

* Convergence layer (CVG), including message flow control, multiplexing and transmission service level control.

divipillai · 2024-05-10T10:20:34Z

nrf_modem/doc/dectphy.rst

+Afterwards, the application can initialize the DECT PHY interface by calling the :c:func:`nrf_modem_dect_phy_init` function.
+Upon successful initialization, both the DECT PHY interface and DECT NR+ physical layer in the modem are ready for operation.
+
+The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware performs a product locking procedure.


Suggested change

The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware performs a product locking procedure.

The very first time the DECT PHY interface is initialized, the DECT NR+ PHY firmware performs a product locking procedure.

nit

eivindj-nordic

Looks good! I think it would be nice with a description of the product locking procedure, though that can be added to the documentation later.

Add libmodem dectphy flavour. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no> Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>

nordicjm · 2024-05-13T07:50:05Z

nrf_modem/CMakeLists.txt

@@ -26,7 +26,11 @@ if(CONFIG_NRF_MODEM_LINK_BINARY)
    set(float_dir soft-float)


other boards are using lowercase letters, these should be aligned:

../nrfxlib/gzll/lib/nrf52810 ../nrfxlib/gzll/lib/nrf52811 ../nrfxlib/gzll/lib/nrf52820 ../nrfxlib/gzll/lib/nrf52832 ../nrfxlib/gzll/lib/nrf52833 ../nrfxlib/gzll/lib/nrf52840 ../nrfxlib/nrf_802154/sl/sl/lib/nrf52833 ../nrfxlib/nrf_802154/sl/sl/lib/nrf52840 ../nrfxlib/nrf_dm/lib/nrf52832 ../nrfxlib/nrf_dm/lib/nrf52833 ../nrfxlib/nrf_dm/lib/nrf52840 ../nrfxlib/gzll/lib/nrf5340_cpunet ../nrfxlib/nrf_802154/sl/sl/lib/nrf5340_cpunet ../nrfxlib/nrf_dm/lib/nrf5340_cpuapp ../nrfxlib/nrf_dm/lib/nrf5340_cpunet

nordicjm · 2024-05-13T07:50:10Z

nrf_modem/CMakeLists.txt

  if(NOT ${CONFIG_SOC} MATCHES "^nrf9160$" AND NOT ${CONFIG_SOC} MATCHES "^nrf91[356]1$")
    message(FATAL_ERROR "Unknown SOC. Expected (nrf9160, nrf9131, nrf9151, nrf9161), "


this should be using Kconfig symbols instead

lemrey requested review from lauri-piikivi, jhirsi, JaniM74, eivindj-nordic, divipillai and laueer May 7, 2024 10:25

lemrey requested review from rlubos and b-gent as code owners May 7, 2024 10:25

github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 7, 2024

This was referenced May 7, 2024

manifest: nrf_modem: add dectphy flavour nrfconnect/sdk-nrf#15199

Merged

samples: dect: add simple sample nrfconnect/sdk-nrf#15201

Merged

eivindj-nordic reviewed May 8, 2024

View reviewed changes

divipillai reviewed May 8, 2024

View reviewed changes

lemrey force-pushed the libmodem-v2.7.0 branch from 02eccf3 to b94f51b Compare May 10, 2024 09:08

divipillai approved these changes May 10, 2024

View reviewed changes

eivindj-nordic approved these changes May 10, 2024

View reviewed changes

lemrey force-pushed the libmodem-v2.7.0 branch 2 times, most recently from d9e286d to 092b7c5 Compare May 10, 2024 14:43

nrf_modem: add dectphy flavour

092b7c5

Add libmodem dectphy flavour. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no> Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>

rlubos merged commit 1e3850d into nrfconnect:main May 13, 2024
4 checks passed

nordicjm requested changes May 13, 2024

View reviewed changes

anhmolt mentioned this pull request May 16, 2024

nrf_modem: cmake soc choice and find binary changes #1331

Merged

lemrey deleted the libmodem-v2.7.0 branch June 14, 2024 07:34

tokangas mentioned this pull request Jan 7, 2025

nrf_modem: doc: Change GNSS interface name #1628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrf_modem: add dectphy flavour #1325

nrf_modem: add dectphy flavour #1325

lemrey commented May 7, 2024

eivindj-nordic May 7, 2024

lemrey May 10, 2024

eivindj-nordic May 7, 2024

lemrey May 8, 2024

lemrey May 10, 2024

eivindj-nordic May 8, 2024

lemrey May 8, 2024

eivindj-nordic May 8, 2024 •

edited

Loading

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 8, 2024

divipillai May 8, 2024

lemrey May 10, 2024

divipillai May 10, 2024

eivindj-nordic left a comment

nordicjm May 13, 2024

nordicjm May 13, 2024

	* system time, the expiry times can not be calculated
	* system time, the expiry times can not be calculated.

	* Added new interface for DECT NR+ PHY firmware.
	* Added new :ref:`interface <nrf_modem_dect_phy>` for the DECT NR+ PHY firmware.

		@@ -9,6 +9,17 @@ Changelog

		All notable changes to this project are documented in this file.

		nrf_modem

	DECT NR+ operates on free but regulated radio channels. The availability of the channels and the exact regulation to use them varies in different countries.
	DECT NR+ operates on free but regulated radio channels.
	The availability of the channels and the exact regulations for using them vary in different countries.


		The physical layer is only one part of the DECT-2020 New Radio protocol stack (DECT NR+).

		The whole DECT NR+ protocol stack consist of four layers:

	The very first time the DECT PHY interface is initialized the DECT NR+ PHY firmware will perform a product locking procedure.
	The very first time the DECT PHY interface is initialized, the DECT NR+ PHY firmware performs a product locking procedure.


		The DECT physical layer (PHY) interface in the Modem library is used to control the DECT NR+ PHY in the DECT NR+ PHY firmware.

		The DECT NR+ PHY firmware is a variant of the nRF9161 firmware with a different feature set than the cellular firmware.

		@@ -26,7 +26,11 @@ if(CONFIG_NRF_MODEM_LINK_BINARY)
		set(float_dir soft-float)

		if(NOT ${CONFIG_SOC} MATCHES "^nrf9160$" AND NOT ${CONFIG_SOC} MATCHES "^nrf91[356]1$")
		message(FATAL_ERROR "Unknown SOC. Expected (nrf9160, nrf9131, nrf9151, nrf9161), "

nrf_modem: add dectphy flavour #1325

nrf_modem: add dectphy flavour #1325

Conversation

lemrey commented May 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eivindj-nordic May 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eivindj-nordic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eivindj-nordic May 8, 2024 •

edited

Loading