-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application: asset_tracker: save power by triggering GPS update on motion #1902
application: asset_tracker: save power by triggering GPS update on motion #1902
Conversation
All checks are passing now. checkpatch (informational only, not a failure)
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
d2dd646
to
ea6b40b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits.
ea6b40b
to
b898c94
Compare
338abae
to
af26581
Compare
It's unclear to me why the Jenkins job has failed. There is no useful information I can glean from it to act on. |
…tion Add GPS_CONTROL_FIX_CHECK_OVERDUE to gps_controller/Kconfig; to be set longer than *_INTERVAL value. Use GPS_START_ON_MOTION to conditionally change gps reporting interval in gps_controller. Add motion_activity_state_t to motion.h. Rewrite motion_handler() in main.c to detect activity/inactivity state. Change structure of it to allow triggering of GPS at end. Add new function motion_trigger_gps() to trigger GPS no faster than shorter GPS_CONTROL_FIX_CHECK_INTERVAL on motion, otherwise revert to new *_OVERDUE value to save power. Enhance gps_controller.c to keep track of most recent time the GPS unit was powered. Use most recent time powered in motion_trigger_gps() to ensure GPS not triggered immediately on every movement (which hurts power consumption). Jira:TG91-7 Signed-off-by: Pete Skeggs <peter.skeggs@nordicsemi.no>
During code review it was noticed that many of the Kconfig help text sections in this file do not follow the indenting standard of one tab plus two spaces. This commit makes them all follow the rule. Signed-off-by: Pete Skeggs <peter.skeggs@nordicsemi.no>
af26581
to
9b97122
Compare
Add GPS_START_ON_MOTION to asset_tracker/Kconfig (default y for Thingy:91).
Add GPS_CONTROL_FIX_CHECK_OVERDUE to gps_controller/Kconfig; to be set longer
than *_INTERVAL value. Use GPS_START_ON_MOTION to conditionally change gps
reporting interval in gps_controller. Add motion_activity_state_t to motion.h.
Rewrite motion_handler() in main.c to detect activity/inactivity state.
Change structure of it to allow triggering of GPS at end. Add new function
motion_trigger_gps() to trigger GPS no faster than shorter
GPS_CONTROL_FIX_CHECK_INTERVAL on motion, otherwise revert to new *_OVERDUE
value to save power. Enhance gps_controller.c to keep track of most recent
time the GPS unit was powered. Use most recent time powered in
motion_trigger_gps() to ensure GPS not triggered immediately on every
movement (which hurts power consumption).