feat: セクションがクリッカブルでないことでトピックと差別化する #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ties-makimura/chibi-ch-i-lo/7PKb9YAFhcF9Gt55UQ9DNfeaMjbm |
|
@knokmki612 さん， もう少し，第1レベルの上下の隙間を縮めて，第2レベルのインデントを大きくとるってできますか？ これぐらいがいいなあ． |
|
@horimasumi 調整しますね |
|
horimasumi さんのコメントとも重複しますが、目次・索引の字下げとして、全角アキ、全角アキ+二分アキ程度の字下げが適当な印象ですね。必ずしもそうでなくともよいとも考えますので、あくまで参考程度までに: Requirements for Japanese Text Layout 日本語組版処理の要件（日本語版） |
|
このように変更しました (オフトピですがなぜか3回重複投稿されましたので重複分削除しました)
|
|
これでお願いします！> @knokmki612 |
|
勢い余ってCI待たずマージしてしまいました…問題あれば別途修正PRを出しますね |
|
と思ったらパスしてました…お騒がせしました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#410 (comment) の対応です
BookChildrenItemのコンポーネントを破棄しているのは、ListItemが ButtonBaseのpropsを渡しているかどうかで、
buttonpropsの型がbooleanでなくtrueかfalseか変化するなど複雑であったのが理由の一つです mui/material-ui#14971