Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lesionwise metrics added (f1-score and abs lesion count diff) #7

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Lesionwise metrics added (f1-score and abs lesion count diff) #7

merged 1 commit into from
Jun 23, 2022

Conversation

ezequieldlrosa
Copy link
Contributor

No description provided.

AlexandreHutton
AlexandreHutton requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@AlexandreHutton AlexandreHutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • new lesion count functions should be removed; they are redundant with existing functions and not used by other parts of this PR.
  • dimensionality problem with F1 computation; you need to deal with the channels.

@AlexandreHutton AlexandreHutton merged commit 76b057c into npnl:main Jun 23, 2022
@AlexandreHutton
Copy link
Member

cc3d caused the entire evaluation to hang when used with multiprocessing.Pool. I'm not sure why. I removed it and used scipy to compute the lesionwise F1 score instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreHutton AlexandreHutton AlexandreHutton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezequieldlrosa @AlexandreHutton