Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consistently reference @babel/core #31

Merged
merged 1 commit into from
Jan 17, 2019
Merged

chore: consistently reference @babel/core #31

merged 1 commit into from
Jan 17, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jan 11, 2019

@SimenB SimenB mentioned this pull request Jan 11, 2019
Merged
jakeNiemiec
jakeNiemiec reviewed Jan 11, 2019
View reviewed changes
accepted/0008-no-caret-prerelease-installs.md
@@ -13,8 +13,8 @@ results in

```diff
"devDependencies": {
Copy link

@jakeNiemiec jakeNiemiec Jan 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at line 9, should this be dependencies?

zkat
zkat approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@zkat zkat merged commit ff42c1b into npm:latest Jan 17, 2019
@SimenB SimenB deleted the patch-1 branch January 20, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeNiemiec jakeNiemiec jakeNiemiec left review comments

@zkat zkat zkat approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimenB @zkat @hzoo @jakeNiemiec