call Date.parse(val) once instead of twice #76

elidoran · 2016-12-12T21:30:07Z

If it's going to create a problem preventing the debug call then it'll create the problem even when it's the last arg to debug. So, might as well do it once, first, and then use that result in the debug call.

@elidoran

If it's going to create a problem preventing the debug call then it'll create the problem even when it's the last arg to debug. So, might as well do it once, first, and then use that result in the debug call. Credit: @elidoran Reviewed-By: @othiym23 PR-URL: #76

othiym23 · 2016-12-13T23:47:58Z

Landed as 39b6e5c, included in nopt@4.0.0. Thanks for putting this together!

call Date.parse(val) once instead of twice

969874e

othiym23 added the review label Dec 12, 2016

othiym23 closed this Dec 13, 2016

othiym23 removed the review label Dec 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

call Date.parse(val) once instead of twice #76

call Date.parse(val) once instead of twice #76

elidoran commented Dec 12, 2016

othiym23 commented Dec 13, 2016

call Date.parse(val) once instead of twice #76

call Date.parse(val) once instead of twice #76

Conversation

elidoran commented Dec 12, 2016

othiym23 commented Dec 13, 2016