fixup! feat: add walk up dir lookup to satisfy local bins

README.md

@@ -31,7 +31,7 @@ await libexec({
   - `call`: An alternative command to run when using `packages` option **String**, defaults to empty string.
   - `cache`: The path location to where the npm cache folder is placed **String**
   - `color`: Output should use color? **Boolean**, defaults to `false`
-  - `localBin`: Location to the `node_modules/.bin` folder of the local project **String** to start scanning for bin files, defaults to `./node_modules/.bin`. **libexec** will walk up the directory structure looking for `node_modules/.bin` folders in parent folders that might satisfy the current `arg` and will use that bin if found.
+  - `localBin`: Location to the `node_modules/.bin` folder of the local project to start scanning for bin files **String**, defaults to `./node_modules/.bin`. **libexec** will walk up the directory structure looking for `node_modules/.bin` folders in parent folders that might satisfy the current `arg` and will use that bin if found.
   - `locationMsg`: Overrides "at location" message when entering interactive mode **String**
   - `log`: Sets an optional logger **Object**, defaults to `proc-log` module usage.
   - `globalBin`: Location to the global space bin folder, same as: `$(npm bin -g)` **String**, defaults to empty string.

lib/file-exists.js

@@ -1,23 +1,26 @@
-const { dirname, resolve } = require('path')
+const { resolve } = require('path')
 const { promisify } = require('util')
 const stat = promisify(require('fs').stat)
+const walkUp = require('walk-up-path')
 
 const fileExists = (file) => stat(file)
   .then((stat) => stat.isFile())
   .catch(() => false)
 
-const localFileExists = async (dir, binName) => {
-  const binDir = resolve(dir, 'node_modules', '.bin')
+const localFileExists = async (dir, binName, root = '/') => {
+  root = resolve(root).toLowerCase()
 
-  // return localBin if existing file is found
-  if (await fileExists(resolve(binDir, binName)))
-    return binDir
+  for (const path of walkUp(resolve(dir))) {
+    const binDir = resolve(path, 'node_modules', '.bin')
 
-  // no more dirs left to walk up, file just does not exist
-  if (dir === dirname(dir))
-    return false
+    if (await fileExists(resolve(binDir, binName)))
+      return binDir
 
-  return localFileExists(dirname(dir), binName)
+    if (path.toLowerCase() === root)
+      return false
+  }
+
+  return false
 }
 
 module.exports = {

package.json

@@ -58,6 +58,7 @@
     "pacote": "^11.3.1",
     "proc-log": "^1.0.0",
     "read": "^1.0.7",
-    "read-package-json-fast": "^2.0.2"
+    "read-package-json-fast": "^2.0.2",
+    "walk-up-path": "^1.0.0"
   }
 }

test/file-exists.js

@@ -0,0 +1,14 @@
+const t = require('tap')
+const { localFileExists } = require('../lib/file-exists.js')
+
+t.test('missing root value', async t => {
+  const dir = t.testdir({
+    b: {
+      c: {},
+    },
+  })
+
+  // root value a is not part of the file system hierarchy
+  const fileExists = await localFileExists(dir, 'foo', 'a')
+  t.equal(fileExists, false, 'should return false on missing root')
+})