This repository was archived by the owner on May 4, 2024. It is now read-only.
Fix method name in README.md #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Looking at line 105 in `theme-set.js`, this should be `newThemeSet`. This makes me wonder if `Gauge.prototype.setThemeset` should be `Gauge.prototype.setThemeSet` for consistency, but that is outside of the scope of this PR and would be a breaking change.
|
@brianloveswords My feeling is that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at line 105 in
theme-set.js, this should benewThemeSet.This makes me wonder if
Gauge.prototype.setThemesetshould beGauge.prototype.setThemeSetfor consistency, but that is outside of the scope of this PR and would be a breaking change.