feat(pkg): add support to empty bracket syntax #3539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d0eae0 to
0a6c68f
Compare
darcyclarke
approved these changes
Jul 13, 2021
ljharb
reviewed
Jul 13, 2021
0a6c68f to
23147e8
Compare
ljharb
reviewed
Jul 13, 2021
76ac9ae to
33ee276
Compare
ljharb
reviewed
Jul 13, 2021
33ee276 to
b43e26b
Compare
ljharb
reviewed
Jul 13, 2021
b43e26b to
2439bec
Compare
ljharb
approved these changes
Jul 13, 2021
wraithgar
reviewed
Jul 14, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
2439bec to
486a266
Compare
ruyadorno
added a commit
that referenced
this pull request
Jul 15, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402 PR-URL: #3539 Credit: @ruyadorno Close: #3539 Reviewed-by: @darcyclarke, @ljharb
|
Landed in 8371d7d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using
npm pkg set, e.g:References
Relates to: npm/rfcs#402
cc @ljharb @darcyclarke