This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: support system root path with no pkg name #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 26, 2020
Considerations
|
|
relates to: npm/cli#1975 (comment) |
Right now if your cwd is / npm exec, npm ls (or any arborist-dependent command) will fail with a "could not detect node name from path or package" error. This patches add a manual "system-root" name to allow arborist to build a tree from / PR-URL: #189 Credit: @ruyadorno Close: #189 Reviewed-by: @isaacs
5190d50 to
bf04701
Compare
|
Trying a different approach: just let it be nameless if it's in the system root path. It should be fine, since we never use system root nodes as anything other than a root node, so it's the only case where it ought to be safe to allow a nameless Node instance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if your cwd is
/npm exec,npm ls(or any arborist-dependentcommand) will fail with a "could not detect node name from path or
package" error.
This patches add a manual
"system-root"name to allow arborist to builda tree from
/