Support message containers introduced in RabbitMQ 3.13.0 #109
Conversation
.github/workflows/action.yml
Outdated
| @@ -2,15 +2,15 @@ name: build | |||
| on: [push, pull_request] | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
I was a bit too optimistic of just changing the CI and expecting it to just work.
I would need some help from your previous experience to make the build work.
I wonder why ppa:rabbitmq/rabbitmq-erlang did not work in the end?
|
@gomoripeti your Build Failed, any chance you could fix that and publish version 0.63 of Plugin? |
|
hi @phil16727 I am not the maintainer of this plugin so I definitely cannot publish a new version. There is some issue with the build infrastructure on newer erlang versions. It is not easy to build elixir plugins for rabbitmq nowadays. I was hoping noxdafox can help based on his prior experience, but I will also try to look at it eventually (not sure when I will find the time) |
|
The issue is RMQ I will try again once I have some spare time which is quite limited atm. Thanks @gomoripeti for the contribution! |
|
@noxdafox @gomoripeti see my PR at #110 https://github.com/dentarg/rabbitmq-message-deduplication/actions/runs/9536833800 built this branch using that (dentarg@5a295bf) |
|
thanks a lot @dentarg I was going to try switching to |
|
rebased to latest main |
This commit makes the plugin depend on the `mc` module and hence 3.13.0+ at runtime. Fixes noxdafox#108
The later implemented in `mix_task_archive_deps` uses `Mix.Dep.load_on_environment/1` which was removed in Elixir 1.16.0. This plugin has no dependencies so the two tasks are mostly equivalent. The mix task `archive.build.elixir` is still used from `mix_task_archive_deps`.
|
You really did an excellent job, @gomoripeti |
|
Thanks for the contribution @gomoripeti! |
This commit makes the plugin depend on the
mcmodule and hence 3.13.0+ at runtime.Fixes #108