Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #548: :i? doesnt provide command description #551

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix #548: :i? doesnt provide command description #551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
200558b
Fix #548: :i? doesnt provide command description
enovella Jan 29, 2024
f37bf1d
Change comments regarding operation at current address
enovella Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agent/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const commandHandlers = {
'ii*': info.listImportsR2,
iij: info.listImportsJson,
il: [info.listModules, 'list libraries'],
'il.': info.listModulesHere,
'il.': [info.listModulesHere, 'list libraries of current offset'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to define an interface for this commandHandlers object so that doesnt fail at runtime. Also if thats the case, there are many other commands that take the function name instead of an array. So im not sure if thats whats expected

'il*': info.listModulesR2,
ilq: info.listModulesQuiet,
ilj: info.listModulesJson,
Expand Down
Loading