Feat/9 nv go 2 api 2 get all notifications

[samsoft00]

Issue: #9

[samsoft00]

@prajjwaldimri can you help review this?

[unicodeveloper]

Please can you update the readme? @samsoft00

[samsoft00]

Sure, I'll also add some tests.

[prajjwaldimri]

@samsoft00 If possible, please convert the query params in this PR to use structs and the new utils function (

go-novu/lib/utils.go

Line 24 in 794b4dd

func GenerateQueryParamsFromStruct[T interface{}](queryParamsStruct T) ([]QueryParam, error) {

), which can dynamically generate params list.

[samsoft00]

Nope, I have reservations regarding this approach, aside, I need to handle array and array string in my current implementation, I'll communicate before Wednesday.

@samsoft00 If possible, please convert the query params in this PR to use structs and the new utils function (

go-novu/lib/utils.go

Line 24 in 794b4dd

func GenerateQueryParamsFromStruct[T interface{}](queryParamsStruct T) ([]QueryParam, error) {

), which can dynamically generate params list.

[prajjwaldimri]

Oh, okay. Let's discuss your reservations and land on one approach for the library, then. Otherwise, different endpoints would have different ways of passing data to them, which would result in a bad experience.

Nope, I have reservations regarding this approach, aside, I need to handle array and array string in my current implementation, I'll communicate before Wednesday.

@samsoft00 If possible, please convert the query params in this PR to use structs and the new utils function (

go-novu/lib/utils.go

Line 24 in 794b4dd

func GenerateQueryParamsFromStruct[T interface{}](queryParamsStruct T) ([]QueryParam, error) {

), which can dynamically generate params list.

[unicodeveloper]

@prajjwaldimri @samsoft00 Any updates here?

[unicodeveloper]

Hey guys @prajjwaldimri @samsoft00 It's been 3 weeks since this PR came up. Can we make a decision asap?

If no decision is made by next week, I'll have to go with an option so we can close this out. 🙏🏿

[unicodeveloper]

@samsoft00 @prajjwaldimri please any updates here?

[prajjwaldimri]

@unicodeveloper This is blocked on @samsoft00.

[unicodeveloper]

@samsoft00 Please can you update the readme? I'll like to merge this in as soon as possible. There are folks requesting for this feature 🙏🏿

[Cliftonz]

@samsoft00 @prajjwaldimri any updates on this?

[Cliftonz]

@samsoft00 there are conflicts that we need to resolve

[solarsoft0]

@samsoft00 @prajjwaldimri any updates on this?

+1