Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test design #3

Closed
wants to merge 3 commits into from
Closed

Refactor test design #3

wants to merge 3 commits into from

Conversation

DongLieu
Copy link

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@DongLieu DongLieu closed this Nov 25, 2022
sontrinh16 pushed a commit that referenced this pull request Mar 15, 2023
@asalzmann
V7 import paths (Stride-Labs#665)
563bc25 
**Summary**
1. Find+replace all instances of `v6` in import paths
2. Regenerate all pb.go files

**Test plan**
ran `make build-docker && make start-docker`
got
```
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
Done
docker-compose -f ./dockernet/docker-compose.yml down
Initializing STRIDE chain...
Node #1 ID: bb7d3c606732160ee6a73701347d9713cd729228@stride1:26656
Node #2 ID: 3fa6e827fdd02aab6ecc324253e0dac58363fc7c@stride2:26656
Node #3 ID: 83df432b4bb7aa03c07ba9f7967bd813dc31bb8a@stride3:26656
Initializing GAIA chain...
Node #1 ID: 8f0f13859d0f6223509da4412108ba7592815140@gaia1:26656
Starting STRIDE chain
[+] Running 4/4
 ⠿ Network dockernet_default      Created                                                0.1s
 ⠿ Container dockernet-stride1-1  Started                                                0.8s
 ⠿ Container dockernet-stride2-1  Started                                                0.8s
 ⠿ Container dockernet-stride3-1  Started                                                0.8s
Starting GAIA chain
[+] Running 1/1
 ⠿ Container dockernet-gaia1-1  Started                                                  0.6s
Waiting for STRIDE to start...Done
Waiting for GAIA to start...Done
STRIDE <> GAIA - Adding relayer keys...Done restoring relayer keys
STRIDE <> GAIA - Creating client, connection, and transfer channel...Done.
[+] Running 1/1
 ⠿ Container dockernet-relayer-gaia-1  Started                                           0.6s
GAIA - Registering host zone...
  code: 0
  txhash: 3BE020C9D245F5856C8B057DA188744FD68CBCF911267E0446C9F4A5988AA190
GAIA - Registering validators...
  code: 0
  txhash: E1A21579AB6D7CD08FD28546E34D35BAB464129C073614E63F99069B4878E79D
Done
```
sontrinh16 pushed a commit that referenced this pull request Mar 27, 2023
@riley-stride
#3
3c79a86
sontrinh16 pushed a commit that referenced this pull request Mar 27, 2023
@riley-stride
#3 (redeem stake msgServer)
bf9c9cd
sontrinh16 pushed a commit that referenced this pull request Mar 27, 2023
@asalzmann
V7 import paths (Stride-Labs#665)
a63fe04 
**Summary**
1. Find+replace all instances of `v6` in import paths
2. Regenerate all pb.go files

**Test plan**
ran `make build-docker && make start-docker`
got
```
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
Done
docker-compose -f ./dockernet/docker-compose.yml down
Initializing STRIDE chain...
Node #1 ID: bb7d3c606732160ee6a73701347d9713cd729228@stride1:26656
Node #2 ID: 3fa6e827fdd02aab6ecc324253e0dac58363fc7c@stride2:26656
Node #3 ID: 83df432b4bb7aa03c07ba9f7967bd813dc31bb8a@stride3:26656
Initializing GAIA chain...
Node #1 ID: 8f0f13859d0f6223509da4412108ba7592815140@gaia1:26656
Starting STRIDE chain
[+] Running 4/4
 ⠿ Network dockernet_default      Created                                                0.1s
 ⠿ Container dockernet-stride1-1  Started                                                0.8s
 ⠿ Container dockernet-stride2-1  Started                                                0.8s
 ⠿ Container dockernet-stride3-1  Started                                                0.8s
Starting GAIA chain
[+] Running 1/1
 ⠿ Container dockernet-gaia1-1  Started                                                  0.6s
Waiting for STRIDE to start...Done
Waiting for GAIA to start...Done
STRIDE <> GAIA - Adding relayer keys...Done restoring relayer keys
STRIDE <> GAIA - Creating client, connection, and transfer channel...Done.
[+] Running 1/1
 ⠿ Container dockernet-relayer-gaia-1  Started                                           0.6s
GAIA - Registering host zone...
  code: 0
  txhash: 3BE020C9D245F5856C8B057DA188744FD68CBCF911267E0446C9F4A5988AA190
GAIA - Registering validators...
  code: 0
  txhash: E1A21579AB6D7CD08FD28546E34D35BAB464129C073614E63F99069B4878E79D
Done
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DongLieu