Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kqueue support for iOS. #533

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Adding kqueue support for iOS. #533

merged 2 commits into from
Sep 20, 2023

Conversation

rizerco
Copy link
Contributor

@rizerco rizerco commented Sep 12, 2023

Added support for kqueue on iOS. I’ve tested on both a device and a simulator and all is working well.

Resolves #519

@rizerco rizerco changed the title Adding Kqueue support for iOS. Adding kqueue support for iOS. Sep 12, 2023
@0xpr03
Copy link
Member

0xpr03 commented Sep 13, 2023

I'll take a look at this later this week

@0xpr03
Copy link
Member

0xpr03 commented Sep 17, 2023

Looks good. There is no fsevent on ios, is there ? Also please add an entry to the readme to document that platform.

@rizerco
Copy link
Contributor Author

rizerco commented Sep 19, 2023

No, I don’t think fsevent exists there. Looking at the docs it seems that everything is listed as macOS only.

I’ve added a little bit to the readme, but let me know if you want anything else added.

Thanks!

@0xpr03 0xpr03 merged commit b912ce5 into notify-rs:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use KqueueWatcher as RecommendedWatcher for iOS
2 participants