-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display correct error on max-files-watch #285
Conversation
On a separate note: We might want to have a list of people than can test stuff like glutin/rust-windowing has. |
See #266 Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
This is blocked by a mac implementation (possibly just another cfg with its error no) which I can't do as I don't have any apple machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, though I also don't have a macOS machine :/ Could we check it with a (temporary) test on CI?
With the help of a friend I've come to the following conclusion: There doesn't seem to be an watch-files limit on mac. And if there would be, you would not get any userland reports.. Also the only real limits seems to be how many watchers you can spawn in parallel until you reach a thread limit, that is reported as "Resource temporarily unavailable" which I think is good enough. Thus I'd only add the linux change and leave everything else as is. |
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
Signed-off-by: Aron Heinecke <aron.heinecke@t-online.de>
This is a draft to display the correct error message when maximum number of files watchable is reached. Under linux you can test this by using the default example and setting
sudo sysctl -w fs.inotify.max_user_watches=1
It currently works as expected on
Windows does not seem to expose some kinds of limits on its API.
I don't have access to a mac system
but they have limit, so it'd be nice to know how its working over there (possibly the same due to libc?). Windows will probably behave completely different.See down below for why macos doesn't seem to need any changes.Fixes #266