Support gpgsig parsing and some extra fixes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Chen <cyen0312@gmail.com>
Without this patch, parsing through commits that are gpg signed would fail. Signed-off-by: Lance Chen <cyen0312@gmail.com>
There are two reasons for removing these lines of code 1. There are no push methods for strings (author_line/committer_line) 2. git does not support multiple authors/committers Signed-off-by: Lance Chen <cyen0312@gmail.com>
I can't find the 'first' property anywhere, though it does not cause any problem. Signed-off-by: Lance Chen <cyen0312@gmail.com>
|
Not sure if I'm doing it right. Please check! 😕 |
|
Could you validate the content of the signature in addition to asserting that it is there? |
|
I don't quite understand your question. Do you mean if I can check whether the signature is a valid gpg signature instead of some forged garbage? |
|
Ah no. Just testing the contents of |
Signed-off-by: Lance Chen <cyen0312@gmail.com>
|
Sorry for the late response. I have added a test case to validate the signature content. |
|
Thank you! |
notatestuser
added a commit
that referenced
this pull request
Jun 6, 2014
Support gpgsig parsing and some extra fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of one major feature and three minor fixes