Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: upgrade to OCI 1.1 (#916)" #958

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao junjiegao@microsoft.com

JeyJeyGao added 2 commits June 6, 2024 15:19
This reverts commit 0f556be.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao force-pushed the revert/oci_image1.1 branch from 7ed1e7d to 43e21e5 Compare June 6, 2024 07:19
@JeyJeyGao JeyJeyGao changed the title revert: feat: upgrade to OCI 1.1 (#916) revert: feat: upgrade to OCI 1.1 (#916 ) Jun 6, 2024
@JeyJeyGao JeyJeyGao changed the title revert: feat: upgrade to OCI 1.1 (#916 ) revert: feat: upgrade to OCI 1.1 #916 Jun 6, 2024
@JeyJeyGao JeyJeyGao changed the title revert: feat: upgrade to OCI 1.1 #916 Revert "feat: upgrade to OCI 1.1 (#916)" Jun 6, 2024
@JeyJeyGao JeyJeyGao changed the title Revert "feat: upgrade to OCI 1.1 (#916)" revert: "feat: upgrade to OCI 1.1 (#916)" Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (6e89dd7) to head (43e21e5).

Current head 43e21e5 differs from pull request most recent head 6836149

Please upload reports for the commit 6836149 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1     #958      +/-   ##
===============================================
- Coverage        71.34%   71.30%   -0.04%     
===============================================
  Files               45       45              
  Lines             2174     2171       -3     
===============================================
- Hits              1551     1548       -3     
  Misses             429      429              
  Partials           194      194              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 789bdd3 into notaryproject:release-1.1 Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants