Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message for trust policy #933

Merged
merged 5 commits into from
May 28, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Apr 24, 2024

This error message improvement is based on the Notation CLI error message improvement guideline that we defined in #834

Resolve part of #934
Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.34%. Comparing base (fd3f69f) to head (967a0cf).

Files Patch % Lines
cmd/notation/policy/show.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   71.27%   71.34%   +0.06%     
==========================================
  Files          45       45              
  Lines        2169     2174       +5     
==========================================
+ Hits         1546     1551       +5     
  Misses        429      429              
  Partials      194      194              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/notation/policy/import.go Outdated Show resolved Hide resolved
cmd/notation/policy/show.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao requested a review from Two-Hearts April 29, 2024 05:57
shizhMSFT
shizhMSFT previously approved these changes Apr 29, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/notation/policy/show.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes May 6, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao requested a review from shizhMSFT May 7, 2024 01:55
cmd/notation/policy/import.go Outdated Show resolved Hide resolved
cmd/notation/policy/import.go Outdated Show resolved Hide resolved
cmd/notation/policy/show.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao requested a review from priteshbandi May 21, 2024 01:47
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit d439bbb into notaryproject:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants