Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update navbar sticky and transition on scroll #21

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: update navbar sticky and transition on scroll #21

merged 1 commit into from
Jul 17, 2023

Conversation

miguelzinh3
Copy link
Contributor

No description provided.

@miguelzinh3 miguelzinh3 self-assigned this Jul 17, 2023
@miguelzinh3 miguelzinh3 marked this pull request as ready for review July 17, 2023 14:47
igr-santos
igr-santos requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@igr-santos igr-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O comportamento de scroll para apresentar o Navbar fica um pouco confuso, exige a necessidade de rolar a página para ver a navegação e isso não é tão subjetivo assim, remover o comportamente de scroll e só corrigir o problema da altura fixa do navbar

@miguelzinh3
Copy link
Contributor Author

O comportamento de scroll para apresentar o Navbar fica um pouco confuso, exige a necessidade de rolar a página para ver a navegação e isso não é tão subjetivo assim, remover o comportamente de scroll e só corrigir o problema da altura fixa do navbar

pronto!

@miguelzinh3 miguelzinh3 requested a review from igr-santos July 17, 2023 15:39
@miguelzinh3 miguelzinh3 merged commit 55ea081 into main Jul 17, 2023
@igr-santos igr-santos deleted the fix/navbar-fixed branch August 15, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpclima96 jpclima96 Awaiting requested review from jpclima96

@igr-santos igr-santos Awaiting requested review from igr-santos

Assignees

@miguelzinh3 miguelzinh3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelzinh3 @igr-santos