#5 Wrong callback called in the traceRoute() method when a session …

…ID cannot be generated
nospaceships · Feb 29, 2016 · 5530898 · 5530898
1 parent 35e56b1
commit 5530898
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.hgignore b/.hgignore
diff --git a/README.md b/README.md
@@ -455,6 +455,11 @@ Bug reports should be sent to <stephen.vickers.sv@gmail.com>.
 
  * Host repository on GitHub
 
+## Version 1.2.0 - 29/02/2016
+
+ * Wrong callback called in the `traceRoute()` method when a session ID cannot
+   be generated
+
 # Roadmap
 
 Suggestions and requirements should be sent to <stephen.vickers.sv@gmail.com>.

diff --git a/index.js b/index.js
@@ -496,7 +496,7 @@ Session.prototype.traceRoute = function (target, ttl, feedCallback,
 	var id = this._generateId ();
 	if (! id) {
 		var sent = new Date ();
-		callback (new Error ("Too many requests outstanding"), target,
+		doneCallback (new Error ("Too many requests outstanding"), target,
 				sent, sent);
 		return this;
 	}