Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for projects using PackageReference model #11

Closed
ImrePyhvel opened this issue Oct 6, 2017 · 2 comments
Closed

Add support for projects using PackageReference model #11

ImrePyhvel opened this issue Oct 6, 2017 · 2 comments
Labels
Milestone

Comments

@ImrePyhvel
Copy link
Collaborator

Visual studio 2017 is supported and working as intended when the old packages.config model is used.

Problem occurs when user chooses the option to store package references in project file. Then the nuget package is installed, but the expected file of /Properties/Nortal.Utilities.AssemblyVersioning.MsBuildTask.props is not copied to project and build will fail. Example error message.
The imported project "W:\temp\ConsoleApp1\ConsoleApp3\Properties\Nortal.Utilities.AssemblyVersioning.MsBuildTask.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.

It should be investigated why nuget package content folder is not respected in this scenario.

The workaround is to manually add the missing file to /Properties/Nortal.Utilities.AssemblyVersioning.MsBuildTask.props from C:\Users\Imre\.nuget\packages\Nortal.Utilities.AssemblyVersioning.MsBuildTask\0.11.0\content\Properties\.

@ImrePyhvel ImrePyhvel added the bug label Oct 6, 2017
@ImrePyhvel ImrePyhvel changed the title Add support for VS2017 when PackageReference in csproj is used Add support for projects using PackageReference model Jan 3, 2021
@ImrePyhvel
Copy link
Collaborator Author

PackageReference model no longer copies files from nuspec files element, but requires files to be set up in contentFiles section.

Also, the latter is intended for immutable files so not suitable for configuration scaffolding.

The intended way forward is to deprecate the props-file way of configuration and aim toward simplified configuration from csproj file itself. Especially considering the simplified SDK-style project files used in .net core projects.

@ImrePyhvel
Copy link
Collaborator Author

Solved as side-product of #12

@ImrePyhvel ImrePyhvel added this to the v0.13 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant