feat: read web content #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondaychen
reviewed
Apr 3, 2024
when voice mode turned on
when voice mode turned off
when voice mode turned on and ask to describe website
when voice mode turned off and ask to describe website
|
e89ead2 to
a0132a4
Compare
mondaychen
reviewed
Apr 3, 2024
| @@ -30,8 +35,27 @@ This is an example of expected response from you: | |||
| } | |||
| } | |||
|
|
|||
| Your response must always be in JSON format and must include string "thought" and object "action", which contains the string "name" of tool of choice, and necessary arguments ("args") if required by the tool. | |||
| { | |||
There was a problem hiding this comment.
when voiceMode is false, maybe add the content in thought instead?
src/state/currentTask.ts
Outdated
| if (voiceMode && "thought" in query.action) { | ||
| voiceControl.speak(query.action.thought, onError); | ||
| if (voiceMode && "speak" in query.action && query.action.speak) { | ||
| voiceControl.speak(query.action.speak, onError); |
There was a problem hiding this comment.
fallback to thought if speak does not exist?
mondaychen
approved these changes
Apr 3, 2024
with voice mode on
with voice mode off
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #88