Use Prior Knowledge in annotation #51
Conversation
| @@ -3,7 +3,7 @@ import OpenAI from "openai"; | |||
| import { useAppState } from "../state/store"; | |||
| import { availableActions, availableActionsVision } from "./availableActions"; | |||
| import { ParsedResponseSuccess } from "./parseResponse"; | |||
| import { fetchKnowledge } from "./knowledge/fetchKnowledge"; | |||
| import { type Knowledge } from "./knowledge"; | |||
There was a problem hiding this comment.
[just curious] why do we need to include 'type' here? is it a convention that as long as it's a type definition, the keyword 'type' should be included when importing?
There was a problem hiding this comment.
yes, it's better to clearly indicate type importing to differentiate from value importing
| let prompt = | ||
| formatPrompt(taskInstructions, previousActions) + | ||
| `Current page progress: ${viewportPercentage.toFixed(1)}%`; | ||
| if (knowledge.length > 0) { | ||
| if (knowledge.notes != null && knowledge.notes?.length > 0) { |
There was a problem hiding this comment.
can be simplified as if (knowledge.notes && knowledge.notes?.length > 0) {
There was a problem hiding this comment.
I think it's good to do != null for non-boolean values
| @@ -134,6 +113,37 @@ function isTouchedElement(elem: Element) { | |||
| ); | |||
| } | |||
|
|
|||
| function getAriaLabel(elem: Element): string { | |||
| // aria-labelledby has higher priority than aria-label | |||
There was a problem hiding this comment.
do we need to check both "aria-labelledby" and "aria-label"? Or these two always exist at the same time?
There was a problem hiding this comment.
we check aria-labelledby first, if it doesn't exist, check aria-label. that's the standard way
No description provided.