-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support speech recognition and text to speech #49
Conversation
9fe06e6
to
fe2de3f
Compare
You are using If this is new to you, please spend some time read |
I think for handling the case "run task immediately" when stop listening, could use an alternative approach than creating an event "document.dispatchEvent(new CustomEvent("stopListening"))" and listen it, could rewrite it in the state management way |
src/common/TaskUI.tsx
Outdated
@@ -50,6 +60,7 @@ const TaskUI = () => { | |||
instructions: state.ui.instructions, | |||
setInstructions: state.ui.actions.setInstructions, | |||
})); | |||
const [voiceMode, setAudioMode] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to the settings state since it should be persisted. But if you are working on the settings view as your next task, we can take care of that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point! I will take care of this during the settings view implementation.
No description provided.