-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supported text-based model #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondaychen
approved these changes
Feb 29, 2024
mondaychen
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry clicked wrong option
mondaychen
requested changes
Feb 29, 2024
… are with selector
lynchee-owo
force-pushed
the
lynchee/text-model
branch
from
March 1, 2024 01:41
699cd5b
to
9b61cc4
Compare
mondaychen
requested changes
Mar 1, 2024
Co-authored-by: Mengdi Chen <monday.chen@gmail.com>
Co-authored-by: Mengdi Chen <monday.chen@gmail.com>
mondaychen
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported text-based model. Specifically, enabled element id based query.
Note: the current way of defining availableActions for both vision-based model and text-based model are sort of hard-coded. Need refactoring so that the name of args can be dynamically determined. Theoretically this should not interfere Typescript's static type checking as it's always string under both cases.