Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supported text-based model #29

Merged
merged 5 commits into from
Mar 1, 2024
Merged

feat: supported text-based model #29

merged 5 commits into from
Mar 1, 2024

Conversation

lynchee-owo
Copy link
Contributor

Supported text-based model. Specifically, enabled element id based query.

Note: the current way of defining availableActions for both vision-based model and text-based model are sort of hard-coded. Need refactoring so that the name of args can be dynamically determined. Theoretically this should not interfere Typescript's static type checking as it's always string under both cases.

Copy link
Contributor

@mondaychen mondaychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry clicked wrong option

src/helpers/rpc/performAction.ts Outdated Show resolved Hide resolved
src/state/currentTask.ts Outdated Show resolved Hide resolved
src/helpers/rpc/performAction.ts Outdated Show resolved Hide resolved
src/helpers/rpc/performAction.ts Outdated Show resolved Hide resolved
lynchee-owo and others added 2 commits March 1, 2024 15:11
Co-authored-by: Mengdi Chen <monday.chen@gmail.com>
Co-authored-by: Mengdi Chen <monday.chen@gmail.com>
@mondaychen mondaychen merged commit 18cf615 into main Mar 1, 2024
3 checks passed
@mondaychen mondaychen deleted the lynchee/text-model branch May 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants