Improve error handling when loading timeout + eslint rules #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading page timed out, we assume it's loaded instead of throwing. This is to handle cases when 1) there's bad link to analytics or ads scripts on the page 2) looping JS that keeps changing the page
Also, introduced new eslint rules
no-throw-literal
andprefer-promise-reject-errors
to ensure we always have error.message to be shown to user