Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when loading timeout + eslint rules #137

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

mondaychen
Copy link
Contributor

@mondaychen mondaychen commented Apr 23, 2024

When loading page timed out, we assume it's loaded instead of throwing. This is to handle cases when 1) there's bad link to analytics or ads scripts on the page 2) looping JS that keeps changing the page

Also, introduced new eslint rules no-throw-literal and prefer-promise-reject-errors to ensure we always have error.message to be shown to user

@mondaychen mondaychen changed the title Improve error handling when loading timeout + eslint rule Improve error handling when loading timeout + eslint rules Apr 23, 2024
@mondaychen mondaychen merged commit 0386568 into main Apr 23, 2024
3 checks passed
@mondaychen mondaychen deleted the better_timeout branch May 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant