fix: skip knowledge display if no notes

normal-computing · Apr 22, 2024 · af01223 · af01223
1 parent bf25d2b
commit af01223
Showing 1 changed file with 39 additions and 15 deletions.
diff --git a/src/common/CustomKnowledgeBase/HostKnowledge.tsx b/src/common/CustomKnowledgeBase/HostKnowledge.tsx
@@ -34,6 +34,20 @@ const HostKnowledge = ({
     ? fetchAllDefaultKnowledge()
     : customKnowledgeBase;
 
+  if (knowledgeBase[host] === undefined) {
+    return null;
+  }
+  if (knowledgeBase[host].rules === undefined) {
+    return null;
+  }
+  const hasNotes = knowledgeBase[host].rules.some(
+    (rule) => (rule.knowledge?.notes?.length ?? 0) > 0,
+  );
+  // skip if no notes
+  if (!hasNotes) {
+    return null;
+  }
+
   const handleRemove = () => {
     const newKnowledge = { ...knowledgeBase };
     delete newKnowledge[host];
@@ -109,21 +123,31 @@ const HostKnowledge = ({
         </Heading>
       </Flex>
       <Accordion allowToggle>
-        {knowledgeBase[host].rules?.map((rule, ruleIndex) => (
-          <AccordionItem key={ruleIndex} backgroundColor="white">
-            <h2>
-              <AccordionButton>
-                <Box flex="1" textAlign="left">
-                  Instructions Set {ruleIndex + 1}
-                </Box>
-                <AccordionIcon />
-              </AccordionButton>
-            </h2>
-            <AccordionPanel pb={4}>
-              <Notes notes={rule.knowledge.notes} />
-            </AccordionPanel>
-          </AccordionItem>
-        ))}
+        {knowledgeBase[host].rules.map((rule, ruleIndex) => {
+          // Skip rules without notes
+          if (
+            rule.knowledge === undefined ||
+            rule.knowledge.notes === undefined ||
+            rule.knowledge.notes.length === 0
+          ) {
+            return null;
+          }
+          return (
+            <AccordionItem key={ruleIndex} backgroundColor="white">
+              <h2>
+                <AccordionButton>
+                  <Box flex="1" textAlign="left">
+                    Instructions Set {ruleIndex + 1}
+                  </Box>
+                  <AccordionIcon />
+                </AccordionButton>
+              </h2>
+              <AccordionPanel pb={4}>
+                <Notes notes={rule.knowledge.notes} />
+              </AccordionPanel>
+            </AccordionItem>
+          );
+        })}
       </Accordion>
     </>
   );